Feature/add roi edit

[sanglevinh]

No description provided.

[sanglevinh]

@ReiHashimoto @itutu-tienday
I changed the loading, pls check it again

Screen.Recording.2023-12-07.at.13.53.21.mov

[itutu-tienday]

@sanglevinh
CC: @ReiHashimoto

Whenever I execute an Edit ROI on a RECORD executed in another branch (such as develop-main at this time), the Roi Edit-related API always seems to respond with a 400 error.
*If the RECORD was generated in this branch, it seems to work fine.

Is this a known issue? (Is backward compatibility of outnput data lost?)

[sanglevinh]

@itutu-tienday As far as I can see, it seems that in the develop-main request Url has not added the workspace_id param, so that's why it happens

[itutu-tienday]

@sanglevinh
Thank you.

request Url has not added the workspace_id param

Which request is this?
Since the pkl file doesn't seem to be read well by BE (I get a 400 error), is this a request that affects the generation of the pkl file?

[sanglevinh]

@itutu-tienday
As far as I see the api, it requires the workspace_id param

[itutu-tienday]

@sanglevinh
Even without calling add_roi, the following operation seems to generate a 400 error.

Example)

1. RUN Workflow in develop-main
2. Switch branch to add_ROI_edit+improve-edit-roi
3. Visualize→Select Roi→select cell_roi
4. Select Edit ROI and 400 error
   • The API for the error is POST /outputs/image/*/status?workspace_id=1.

If you don't mind, could you please share the above with BE's?

@ReiHashimoto
Can you reproduce it in your environment?

[sanglevinh]

@itutu-tienday
I talked to BE,
The ROI editing data of develop and improve-edit-roi are not the same, causing error 400

[ReiHashimoto]

@itutu-tienday @sanglevinh

Even without calling add_roi, the following operation seems to generate a 400 error.

It reproduces in my environment, too.
On selecting roi data, it calls /image/{filepath:path}/status endpoint.

The ROI editing data of develop and improve-edit-roi are not the same, causing error 400

Yes, in improve-edit-roi branch, "edit_roi_data" was added to output dict.
e.g. studio/app/optinist/wrappers/suite2p/roi.py

info = {
    "ops": Suite2pData(ops),
    ...
    "edit_roi_data": EditRoiData(images=ImageData(ops["filelist"]).data, im=im),
    "nwbfile": nwbfile,
}

I think the cause is the following BE code.

studio/app/optinist/core/edit_ROI/edit_ROI.py

self.data = self.output_info.get("edit_roi_data", {})
self.tmp_data: EditRoiData = self.tmp_output_info.get(
    "edit_roi_data", self.data  
)

if not isinstance(self.tmp_data, EditRoiData):
    raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST)

at self.tmp_data: EditRoiData ...,
if we can't get data with "edit_roi_data" key, maybe we need to assign new EditRoiData instance.