Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings and docs for multiuser mode #364

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Update settings and docs for multiuser mode #364

merged 7 commits into from
Jul 2, 2024

Conversation

itutu-tienday
Copy link
Collaborator

@itutu-tienday itutu-tienday commented Jun 25, 2024 •
edited
Loading

  • Contents

    • Update settings
      • Add docker-compose.dev.multiuser.yml to use multiuser mode in docker.
      • Applied patch to Dockerfile (fixed unavailability of alembic command)
    • Update docs
      • Updated multiuser mode setup documentation. ( host_for_multiuser/setup.md )
        • Added clear setup instructions for docker.
        • Corrected other errors and confusing parts.

  • Testing

    • Confirmed that "docker + multiuser mode" can be setup by following the documentation and using above docker-compose yaml.
    • Converted results to HTML (sphinx) also confirmed.

@itutu-tienday itutu-tienday changed the title Update settigs and docs for multiuser mode Update settings and docs for multiuser mode Jun 25, 2024
milesAraya
milesAraya reviewed Jun 26, 2024
View reviewed changes
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/host_for_multiuser/setup.md Show resolved Hide resolved
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/host_for_multiuser/setup.md Show resolved Hide resolved
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/host_for_multiuser/setup.md Show resolved Hide resolved
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/installation/docker_for_developer.md Show resolved Hide resolved
itutu-tienday
itutu-tienday commented Jun 26, 2024
View reviewed changes
Copy link
Collaborator Author

@itutu-tienday itutu-tienday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milesAraya
I have responded once and for all to the comments we have received. Please check them.

docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/host_for_multiuser/setup.md Show resolved Hide resolved
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
docs/host_for_multiuser/setup.md Show resolved Hide resolved
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
@itutu-tienday itutu-tienday requested a review from milesAraya June 27, 2024 01:48
milesAraya
milesAraya approved these changes Jun 27, 2024
View reviewed changes
docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
itutu-tienday
itutu-tienday commented Jun 28, 2024
View reviewed changes
Copy link
Collaborator Author

@itutu-tienday itutu-tienday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The points raised so far have been addressed.

*Please share the status of any conversations that are still outstanding.

docs/host_for_multiuser/setup.md Outdated Show resolved Hide resolved
@itutu-tienday itutu-tienday mentioned this pull request Jul 1, 2024
Closed
@emuemuJP emuemuJP merged commit 16eacd3 into develop-main Jul 2, 2024
5 checks passed
@itutu-tienday itutu-tienday mentioned this pull request Jul 2, 2024
Closed
@itutu-tienday itutu-tienday deleted the feature/update-multiuser-settings branch September 18, 2024 03:55
@itutu-tienday itutu-tienday added this to the ver1.2.2 milestone Nov 2, 2024
@itutu-tienday itutu-tienday mentioned this pull request Nov 19, 2024
Closed
41 tasks
itutu-tienday pushed a commit to arayabrain/optinist-for-server that referenced this pull request Nov 21, 2024
Update documents
cdf2b08 
- porting from
  - arayabrain#366
  - arayabrain#364
  - arayabrain#345
  - arayabrain#382
  - arayabrain#415
  - arayabrain#476
@itutu-tienday itutu-tienday mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesAraya milesAraya milesAraya approved these changes

@emuemuJP emuemuJP emuemuJP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ver1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@itutu-tienday @emuemuJP @milesAraya