Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature:funciton branch #66

Merged
merged 6 commits into from
Sep 27, 2023
Merged

feature:funciton branch #66

merged 6 commits into from
Sep 27, 2023

Conversation

emuemuJP
Copy link
Collaborator

No description provided.

@itutu-tienday itutu-tienday linked an issue Sep 25, 2023 that may be closed by this pull request
[No.27]分岐のあるパイプラインでの保存に対応 oist/optinist#519
Closed
@ReiHashimoto
Copy link

図のように異なる関数で終了する分岐があるパイプラインの際に、一方の結果しかnwbファイルに保存されていない問題を修正。
Screenshot 2023-09-26 at 23 49 14

  • 原因は、whole_{func_name}.nwbの命名規則で全体結果のNWBファイルが保存されており、図のパイプラインの場合は以下の2種類のファイルが生成されていたため。

    • whole_caiman_cnmf.nwb
    • whole_suite2p_roi.nwb

  • 保存ファイル名をwhole.nwbとすることで、これらの結果が同一ファイルに書き込まれるようになったことを確認。
    Screenshot 2023-09-26 at 23 55 12

@ReiHashimoto ReiHashimoto mentioned this pull request Sep 27, 2023
Closed
@ReiHashimoto ReiHashimoto merged commit 2d4a270 into develop-main Sep 27, 2023
@ReiHashimoto ReiHashimoto deleted the feature/function-branch branch September 27, 2023 06:22
@ReiHashimoto ReiHashimoto mentioned this pull request Sep 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReiHashimoto ReiHashimoto ReiHashimoto approved these changes

Assignees

@ReiHashimoto ReiHashimoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[No.27]分岐のあるパイプラインでの保存に対応
2 participants
@emuemuJP @ReiHashimoto