Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in run #76

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix bugs in run #76

merged 1 commit into from
Sep 27, 2023

Conversation

ReiHashimoto
Copy link

概要

パラメータ変更時のRUNのbug fix

  • workflow画面のoutputが更新されない問題
  • workflow.yamlのパラメータが更新されていない問題

テストケース

ワークフロー

  • mouse2p.tif -> caiman_mc -> caiman_cnmf

操作

  1. caiman_cnmfのKを4でRUN_ALL
  2. WORKFLOW画面でOUTPUT(cell_roiなど)を確認
  3. RECORDSからworkflowファイルをダウンロード
  4. caiman_cnmfのKを8に変更してRUN
  5. WORKFLOW画面でOUTPUT(cell_roiなど)を確認
    • 最新の出力が表示される
  6. RECORDSからworkflowファイルをダウンロード
    • Kパラメータが4のファイルと変わっている

Copy link
Collaborator

@itutu-tienday itutu-tienday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正により、想定される動作となっていることを確認。

@ReiHashimoto ReiHashimoto merged commit 4d61f47 into develop-main Sep 27, 2023
3 checks passed
@ReiHashimoto ReiHashimoto deleted the feature/fix-run branch September 27, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants