Feature/database #52
Merged
Feature/database #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
quanpython
force-pushed
the
feature/database
branch
from
720c7d1 to
e5dd662
Compare
quanpython
force-pushed
the
feature/database
branch
from
7950ee3 to
aee93fb
Compare
ReiHashimoto
suggested changes
Jul 14, 2023
ReiHashimoto
suggested changes
Jul 14, 2023
Closed
|
@quanpython cc: @itutu-tienday dev container is OK. But prod container still fails with following errors. |
| sortOptions: SortOptions = Depends(), | ||
| db: Session = Depends(get_db), | ||
| ): | ||
| data = paginate( |
There was a problem hiding this comment.
If there is no particular reason, it would be good to wrap the search_db_cells() function.
| options: ExpDbExperimentsSearchOptions = Depends(), | ||
| sortOptions: SortOptions = Depends(), | ||
| ): | ||
| data = paginate( |
There was a problem hiding this comment.
"experiments_share_users" table is not used. Please use it.
- If you are an administrator role, all data of your organization is displayed. If you are a non-administrator role, only the data allowed by experiments_share_users table is displayed.
- For the table of roles, please refer to the following
| options: ExpDbExperimentsSearchOptions = Depends(), | ||
| sortOptions: SortOptions = Depends(), | ||
| ): | ||
| data = paginate( |
There was a problem hiding this comment.
When using the "experiments_share_users" table, an authentication operation (token parsing) process is required to identify the user_id.
Since it would be more efficient to omit the passing of authentication token during development, we would like to have a mode in which the passing of authentication token can be omitted (i.e., a mode in which token and user_id for debugging can be used).
| if not exp: | ||
| raise HTTPException(status_code=404) | ||
| exp.publish_status = int(flag == PublishFlags.on) | ||
| db.add(exp) |
There was a problem hiding this comment.
"Data publish" is updating experiments.publish_status, not adding records, but are you creating a new experiments in the following?
There was a problem hiding this comment.
exp is an existing experiment object from the database. So db.add(exp) line adds the modified experiment to the database session to update it rather than create a new one.
To avoid misunderstandings, if the experiment object is already associated with the database session, it is better to omit the db.add(exp) line.
Thank you.
| db.query(optinist_model.Experiment) | ||
| .join( | ||
| common_model.Organization, | ||
| common_model.Organization.id == optinist_model.Experiment.organization_id, |
There was a problem hiding this comment.
users.organizasion_id and also requires a join, do you have any discrepancies in perception?
| if not exp: | ||
| raise HTTPException(status_code=404) | ||
| exp.share_type = data.share_type | ||
| db.add(exp) |
There was a problem hiding this comment.
- "Data publish" is updating experiments.publish_status, not adding records, but are you creating a new experiments in the following?
- There are multiple data parameters, and for the experiments_share_users table, the operation is to replace all existing data (delete all -> register all).
@ReiHashimoto |
|
@quanpython |
itutu-tienday
requested changes
Jul 18, 2023
| MYSQL_USER=docker | ||
| MYSQL_PASSWORD=docker | ||
| ECHO_SQL=True | ||
| DATABASE_URL=mysql+pymysql://docker:docker@db/docker |
There was a problem hiding this comment.
Some of the data in DATABASE_URL and MYSQL_* are duplicated, is it possible to manage them smartly in one place?
There was a problem hiding this comment.
Yes. Just use MYSQL_* is enough because DATABASE_URL is generate from assemble_db_connection function in studio/app/common/db/config.py
itutu-tienday
approved these changes
Jul 18, 2023
itutu-tienday
approved these changes
Jul 18, 2023
ReiHashimoto
approved these changes
Jul 18, 2023
quanpython
force-pushed
the
feature/database
branch
2 times, most recently
from
0b4afd1 to
19501db
Compare
Merged
Merged
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.