Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow navigation #89

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Update workflow navigation #89

merged 7 commits into from
Aug 8, 2023

Conversation

ReiHashimoto
Copy link

@ReiHashimoto ReiHashimoto commented Jul 31, 2023 •
edited
Loading

変更点

  • fetch apiの追加
    • 指定したworkspaceで最後に実行されたworkflowのexperiment.yamlの情報を返す
    • frontendではfetch apiから取得した内容をworkflow画面に反映
  • update react-flow-renderer to v10 #62 で、nodeを削除した際に結合しているedgeがstateから削除されていなかったバグを修正
  • Workspaces画面からWorkflow, Results画面への遷移を追加
    • 画面遷移の際にGET workflow/{id} APIを実行し、アクセス権をチェック
  • Workflow画面でWorkspaceのオーナーではない場合にRUNボタンを非活性にする制御を追加

備考

  • WorkspaceのIDの型定義がnumber, string混在していたため、numberに寄せています

@ReiHashimoto ReiHashimoto self-assigned this Jul 31, 2023
@ReiHashimoto ReiHashimoto marked this pull request as draft July 31, 2023 22:40
@ReiHashimoto ReiHashimoto force-pushed the feature/switch-workflow-auth branch 2 times, most recently from cbc6705 to 0c7d9c8 Compare August 7, 2023 03:52
@ReiHashimoto ReiHashimoto mentioned this pull request Aug 7, 2023
Closed
@ReiHashimoto ReiHashimoto marked this pull request as ready for review August 7, 2023 04:00
@ReiHashimoto ReiHashimoto force-pushed the feature/switch-workflow-auth branch from 0c7d9c8 to b6d2d45 Compare August 7, 2023 07:30
@ReiHashimoto ReiHashimoto linked an issue Aug 7, 2023 that may be closed by this pull request
5-1. Workflow画面実装 #21
Closed
@ReiHashimoto ReiHashimoto changed the title Update workflow navigatioin Update workflow navigation Aug 7, 2023
@ReiHashimoto
Copy link
Author

共有されたworkspaceの場合、recordsの削除ボタンを表示しないように修正しました

Screenshot 2023-08-08 at 13 54 11

@itutu-tienday itutu-tienday merged commit d723a6c into develop-main Aug 8, 2023
@ReiHashimoto ReiHashimoto deleted the feature/switch-workflow-auth branch August 8, 2023 05:33
@ReiHashimoto ReiHashimoto mentioned this pull request Aug 17, 2023
Merged
@ReiHashimoto ReiHashimoto mentioned this pull request Sep 22, 2023
Merged
20 tasks
sanglevinh pushed a commit that referenced this pull request Oct 16, 2023
@itutu-tienday
Merge pull request #89 from arayabrain/feature/switch-workflow-auth
d4ddb90 
Update workflow navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itutu-tienday itutu-tienday itutu-tienday approved these changes

Assignees

@ReiHashimoto ReiHashimoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5-1. Workflow画面実装
2 participants
@ReiHashimoto @itutu-tienday