skip body check on GET and HEAD.

Closes #1.
arb · Jun 2, 2016 · e9d658b · e9d658b
1 parent 65b139f
commit e9d658b
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -38,7 +38,13 @@ module.exports = (schema) => {
       Insync.apply(validateSource, 'headers'),
       Insync.apply(validateSource, 'params'),
       Insync.apply(validateSource, 'query'),
-      Insync.apply(validateSource, 'body')
+      (next) => {
+        const method = req.method.toLowerCase();
+        if (method === 'get' || method === 'head') {
+          return next();
+        }
+        validateSource('body', next);
+      }
     ], next);
   };
 };
diff --git a/test/index.js b/test/index.js
@@ -1,8 +1,8 @@
 'use strict';
 
 const Code = require('code');
-const Lab = require('lab');
 const Joi = require('joi');
+const Lab = require('lab');
 const Celebrate = require('../lib');
 
 const lab = exports.lab = Lab.script();
@@ -84,7 +84,8 @@ describe('Celebrate Middleware', () => {
       body: {
         first: 'john',
         last: 123
-      }
+      },
+      method: 'POST'
     }, null, (err) => {
       expect(err).to.exist();
       expect(err.isJoi).to.be.true();
@@ -133,7 +134,8 @@ describe('Celebrate Middleware', () => {
         first: 'john',
         last: 'doe'
       },
-      query: undefined
+      query: undefined,
+      method: 'POST'
     };
     const middleware = Celebrate({
       body: {
@@ -155,4 +157,25 @@ describe('Celebrate Middleware', () => {
       done();
     });
   });
+
+  it('does not validate req.body if the method is "GET" or "HEAD"', (done) => {
+    const middleware = Celebrate({
+      body: {
+        first: Joi.string().required(),
+        last: Joi.string(),
+        role: Joi.number().integer()
+      }
+    });
+
+    middleware({
+      body: {
+        first: 'john',
+        last: 123
+      },
+      method: 'GET'
+    }, null, (err) => {
+      expect(err).to.be.undefined();
+      done();
+    });
+  });
 });