Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Video Details API #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feature Video Details API #10

wants to merge 5 commits into from

Conversation

aleemnadeem
Copy link
Contributor

No description provided.

events/v1/views.py Outdated Show resolved Hide resolved
events/v1/views.py Outdated Show resolved Hide resolved
events/v1/views.py Show resolved Hide resolved
VideoAsset.objects.select_related('event__creator').prefetch_related('event__tags'),
event_id=self.kwargs["pk"]
)
return obj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL

Copy link
Contributor

@arslanather arslanather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#14

Let's wait for above PR to merge and rebase this PR before merging.

@sameeramin
Copy link
Member

Hey @aleemnadeem please rebase this PR to get this merged.

@arslanather
Copy link
Contributor

Hey @aleemnadeem , You will also need to change the serializer to accommodate for new video_file and thumbnail fields.

@aleemnadeem
Copy link
Contributor Author

Hey @aleemnadeem , You will also need to change the serializer to accommodate for new video_file and thumbnail fields.

@arslanather Will the video and thumbnail file be included in the API response?

@arslanather
Copy link
Contributor

Hey @aleemnadeem , You will also need to change the serializer to accommodate for new video_file and thumbnail fields.

@arslanather Will the video and thumbnail file be included in the API response?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants