Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier user access to probe metadata #1079

Closed
halfflat opened this issue Jul 2, 2020 · 0 comments · Fixed by #1101
Closed

Easier user access to probe metadata #1079

halfflat opened this issue Jul 2, 2020 · 0 comments · Fixed by #1101
Assignees

Comments

@halfflat
Copy link
Contributor

halfflat commented Jul 2, 2020

With cable cell probes being defined over locsets rather than concrete locations, @noraabiakar has observed that it is a painful process to extract the corresponding concrete locations from an opaque recipe.

It's also pretty much impossible to get the metadata associated with a cell-wide cable cell probe without waiting for a sampler to be triggered and extracting the metadata from there.

Proposal: add an interface to arb::simulation and the cell group classes that allows metadata retrieval after simulation initialization.

@halfflat halfflat self-assigned this Jul 2, 2020
noraabiakar pushed a commit that referenced this issue Aug 27, 2020
* Add `get_probe_metadata` method to `simulator` that forwards probe metadata queries to appropriate cell group, via new interface method in cell group base class.
* Replace `gid_to_local_` map in simulator implementation with a map that takes gid to local cell index _and_ local cell group index.
* Move scheduler association map mutex into the cell group where it is being used (i.e. `mc_cell_group`).
* Add generic (`visit`-able) interface to specifc fvm-probe types for accessing metadata via `any_ptr`.
* Implement (override) `get_probe_metadata` method for `mc_cell_group`.
* Use new cv policy API for LFP example discretization.
* Use new probe metadata API to simplify LFP example sampler callback.
* Add `on_components` locset expression that gives points a relative distance from the head of each component of a region.
* Simplify implementation of thingification of `ls::boundary`.

Fixes #1079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant