Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that mechanisms have the right kind #1633

Merged
merged 4 commits into from
Aug 27, 2021

Conversation

noraabiakar
Copy link
Contributor

  • Expose arb_mechanism_kind to mechanism_info.
  • While building mechanism data in fvm_build_mechanism_data, check that synapses, painted region dynamics and reversal potential methods have the expected arb_mechanism_kind.
  • Add unit test.

Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add a kind property to the Python interface
of mechinfo and extend the docs accordingly.

Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bcumming bcumming merged commit 37dd7de into arbor-sim:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants