Add locset expressions for proximal and distal translation of locations #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraabiakar
suggested changes
Sep 24, 2021
| }; | ||
|
|
||
| for (auto c: start) { | ||
| std::stack<branch_interval> branches_reached; |
There was a problem hiding this comment.
Does this need to be a stack? It doesn't hurt, but we just sort the generated locsets in the end.
There was a problem hiding this comment.
The algorithm effectively uses a depth-first search to traverse the sub-trees, for which a stack is the natural fit.
The actual branch sections in the output are stored in a different data structure: the std::vector L.
doc/concepts/labels.rst
Outdated
| The set of locations that correspond to moving each location in ``ls`` in the distal direction | ||
| ``distance`` μm or to a terminal location, whichever is closest. | ||
| The number of locations in the output is greater than or equal the number in the input, with | ||
| multiple locations generated from input locations that are less than ``distance`` μm |
There was a problem hiding this comment.
I think I mean less, but might have to reword it to make sense.
There was a problem hiding this comment.
Ah I actually see it now.
noraabiakar
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
proximal-translateanddistal-translatelocset expressions.Fixes #1662