Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makejobs arg #1673

Merged
merged 7 commits into from
Oct 7, 2021
Merged

Makejobs arg #1673

merged 7 commits into from
Oct 7, 2021

Conversation

Helveg
Copy link
Collaborator

@Helveg Helveg commented Sep 20, 2021

Added a --makejobs=4 user option to setup.py to control how many jobs should be started to make the project during the installation.

Depends on #1672 to avoid duplicate defenition of the arg and merge issues.

Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you advertise the flag in doc/install/python.rst? Under the Advanced Options header.

Default of 2 is OK with me.

@Helveg Helveg requested a review from brenthuisman September 20, 2021 14:01
Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but there are some merge issues. Can you merge master?

@brenthuisman brenthuisman merged commit 4766936 into arbor-sim:master Oct 7, 2021
@Helveg Helveg deleted the makejobs-arg branch October 7, 2021 12:12
max9901 pushed a commit to max9901/arbor that referenced this pull request Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants