Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write build-catalogue (c)make errors to stdout and stderr #1679

Merged
merged 5 commits into from
Oct 7, 2021

Conversation

Helveg
Copy link
Collaborator

@Helveg Helveg commented Sep 22, 2021

build-catalogue gobbled up the underlying (c)make output in the uncaught CalledProcessError.stderr and .stdout attributes.

`build-catalogue` gobbled up the underlying (c)make output in the uncaught `CalledProcessError`s `e.stderr` and `e.stdout`.
@Helveg Helveg changed the title Write (c)make errors to stdout and stderr Write build-catalogue (c)make errors to stdout and stderr Sep 22, 2021
Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have the shutil line in the try block, to keep the flow of the build in one consecutive block.

@Helveg Helveg requested a review from brenthuisman September 27, 2021 11:44
@Helveg
Copy link
Collaborator Author

Helveg commented Sep 28, 2021

There's an error, if verbose=True and there's an error then e.stderr and e.stdout are None because they weren't piped. Is it sufficient to just print Check the log above for the error? The way verbose works now is nice because you can follow the progress as it goes. To keep this "feature" we'd have to make a little event loop that uses p.communicate() to read the pipes.

@Helveg Helveg mentioned this pull request Oct 4, 2021
@Helveg Helveg requested a review from brenthuisman October 6, 2021 13:35
@brenthuisman brenthuisman merged commit 11ad487 into arbor-sim:master Oct 7, 2021
@Helveg Helveg deleted the patch-1 branch October 7, 2021 12:03
max9901 pushed a commit to max9901/arbor that referenced this pull request Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants