-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write build-catalogue (c)make errors to stdout
and stderr
#1679
Conversation
`build-catalogue` gobbled up the underlying (c)make output in the uncaught `CalledProcessError`s `e.stderr` and `e.stdout`.
stdout
and stderr
stdout
and stderr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to have the shutil
line in the try block, to keep the flow of the build in one consecutive block.
There's an error, if |
build-catalogue
gobbled up the underlying (c)make output in the uncaughtCalledProcessError.stderr
and.stdout
attributes.