Allow to limit Poisson schedule with a stop time (closes #1617) #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to limit Poisson schedule with a stop time using the same semantics as the regular schedule.
noraabiakar
suggested changes
Sep 29, 2021
noraabiakar
reviewed
Sep 30, 2021
| @@ -256,6 +268,8 @@ void register_schedules(py::module& m) { | |||
| "The expected frequency [kHz].") | |||
| .def_readwrite("seed", &poisson_schedule_shim::seed, | |||
| "The seed for the random number generator.") | |||
| .def_property("tstop", &poisson_schedule_shim::get_tstop, &poisson_schedule_shim::set_tstop, | |||
| "No events delivered after this time [ms].") | |||
There was a problem hiding this comment.
std::ostream& operator<<(std::ostream& o, const poisson_schedule_shim& p) (line 27 of this file) needs to be amended to print out the tstop time as well.
max9901
pushed a commit
to max9901/arbor
that referenced
this pull request
Oct 11, 2021
Limit poisson schedule with a stop time using the same semantics as the regular schedule. closes arbor-sim#1617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to limit Poisson schedule with a stop time using the same
semantics as the regular schedule.