Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cos and sin SVE implementations #1744

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

noraabiakar
Copy link
Contributor

@noraabiakar noraabiakar commented Nov 2, 2021

Add SVE implementations of sin and cos using std::sin and std::cos respectively.
Fixes failing CI on a64fx architectures for vectorized builds.

@noraabiakar
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 2, 2021
@noraabiakar
Copy link
Contributor Author

bors try

@bors
Copy link

bors bot commented Nov 2, 2021

try

Already running a review

@bors
Copy link

bors bot commented Nov 2, 2021

try

Build failed:

@noraabiakar
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 2, 2021
@bors
Copy link

bors bot commented Nov 2, 2021

try

Build failed:

@noraabiakar noraabiakar marked this pull request as ready for review November 2, 2021 14:34
@noraabiakar
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 2, 2021
@bors
Copy link

bors bot commented Nov 2, 2021

try

Build failed:

@noraabiakar
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Nov 2, 2021
@bors
Copy link

bors bot commented Nov 2, 2021

try

Build succeeded:

Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bcumming bcumming merged commit 6c685c0 into arbor-sim:master Nov 2, 2021
bcumming pushed a commit to bcumming/arbor that referenced this pull request Dec 3, 2021
Add SVE implementations of `sin` and `cos` using `std::sin` and `std::cos` respectively. 
Fixes failing CI on a64fx architectures for vectorized builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants