Bug fix: properly partition networks containing one-sided gap-junction connections #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraabiakar
changed the title
schmitts
pushed a commit
to schmitts/arbor
that referenced
this pull request
Nov 25, 2021
Fix various non-standards compliant code when compiled with elevated warning levels (-Wall -Wpedantic). Here is a list of the problems addressed: **preprocessor** - expansion of empty `__VA_ARGS__` in `ARB_PP_FOREACH` - named variadic macro arguments in `TRACE` macro **glibc** - deprecated `mallinfo` call for newer glibc versions **simd** - non-const C-array sizes **modcc** - generation of C-arrays of size 0 **switch/case** - switch-case ranges **tuple_foreach** - compound literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
partition_load_balancefunction assumes that gap-junction connections are always double-sided (i.e. if gidxhas a gap-junction connection from peer gidy, then gidymust also have a gap-junction connection from peer gidx). This used to be a requirement that was checked prior to #1682. Since then, single-sided gap-junctions are in principle allowed butpartition_load_balancestill operates under the double-sided gap-junction connection assumption resulting in some gids being present in multiple cell-groups.This PR corrects the previous assumption and fixes the bug.
Fixes #1767.