Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate external catalogues from libarbor.a. #1837

Merged
merged 15 commits into from
Jun 10, 2022
Merged

Isolate external catalogues from libarbor.a. #1837

merged 15 commits into from
Jun 10, 2022

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Feb 14, 2022 •
edited
Loading

Changes

  • Bump ABI to v0.1.1
  • Add arb_mechanism to bundle type and interfaces
  • Adjust generate_catalogue and build_catalogue
  • Return nullptr for GPU interfaces if not enabled

Open Questions

  • How to tell CMake not to link against libarbor.a and only use headers?
  • How to get around #ifdef ARB_GPU_ENABLED Update: just embrace it.

Linked Issues

Fixes #1834

@bcumming bcumming self-assigned this Feb 14, 2022
@bcumming
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Feb 14, 2022
@bors
Try #1837:
feaa621
@bors
Copy link

bors bot commented Feb 14, 2022

try

Build failed:

@thorstenhater
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Feb 14, 2022
@bors
Try #1837:
c486b73
@bors
Copy link

bors bot commented Feb 14, 2022

try

Build failed:

@thorstenhater
Copy link
Contributor Author

bors try

@thorstenhater
Copy link
Contributor Author

Ran the full suite on JUWELS. No troubles. @bcumming

@thorstenhater
Copy link
Contributor Author

bors try

@bors
Copy link

bors bot commented Feb 16, 2022

try

Already running a review

@thorstenhater
Copy link
Contributor Author

bors try

@bors
Copy link

bors bot commented Feb 22, 2022

try

Already running a review

bcumming
bcumming requested changes Feb 22, 2022
View reviewed changes
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is a tiny suggested update to the docs.

@bcumming
Copy link
Member

bors try

@bors
Copy link

bors bot commented Feb 22, 2022

try

Already running a review

bors bot added a commit that referenced this pull request Feb 24, 2022
@bors
Try #1837:
bc01db5
@bors
Copy link

bors bot commented Feb 24, 2022

try

Build failed:

@thorstenhater
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 25, 2022
@bors
Try #1837:
7f0a724
@bors
Copy link

bors bot commented Mar 25, 2022

try

Build failed:

@thorstenhater
Copy link
Contributor Author

bors try

@thorstenhater
Copy link
Contributor Author

bors try

@bors
Copy link

bors bot commented Apr 29, 2022

try

Already running a review

bors bot added a commit that referenced this pull request Apr 30, 2022
@bors
Try #1837:
b3c1ac4
@bors
Copy link

bors bot commented Apr 30, 2022

try

Build failed:

@brenthuisman
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 4, 2022
@bors
Try #1837:
ba4c39d
@bors
Copy link

bors bot commented May 4, 2022

try

Build failed:

@thorstenhater
Copy link
Contributor Author

Seems stuck on Arm SVE ... no reason. @bcumming can you rescue us?

@brenthuisman
Copy link
Contributor

Let's give @bcumming till the end of the week, and merge if no further feedback was obtained. ARM is no showstopper ATM.

@thorstenhater
Copy link
Contributor Author

@bcumming 👋

@brenthuisman
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Jun 10, 2022
@bors
Try #1837:
a9c52c4
@bors
Copy link

bors bot commented Jun 10, 2022

try

Build failed:

@brenthuisman
Copy link
Contributor

Since AULT failing is the only test not passing, as per agreement past team meeting, I'll force merge.

@brenthuisman brenthuisman merged commit de06afa into arbor-sim:master Jun 10, 2022
@thorstenhater thorstenhater deleted the abi/bridge-catalogue-creation branch August 1, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz left review comments

@bcumming bcumming bcumming requested changes

Assignees

@bcumming bcumming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard-coded path to compiler spoils creating custom catalogue
4 participants
@thorstenhater @bcumming @brenthuisman @eli-schwartz