Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Black for Python. #1906

Merged
merged 10 commits into from
Jun 16, 2022
Merged

Adopt Black for Python. #1906

merged 10 commits into from
Jun 16, 2022

Conversation

thorstenhater
Copy link
Contributor

Add black formatter

@brenthuisman
Copy link
Contributor

Building docs is not part of our tests, but relies on much of our Python code. Can you confirm it builds fine?

@thorstenhater
Copy link
Contributor Author

thorstenhater commented Jun 13, 2022 •
edited
Loading

They do. All the literal include lines are in jeopardy though. As discussed elsewhere, this should be merged in close
succession with the two other Python PRs and then the line numbers must be fixed immediately.

@thorstenhater thorstenhater mentioned this pull request Jun 13, 2022
Merged
@Helveg
Copy link
Collaborator

Helveg commented Jun 13, 2022 •
edited
Loading

What about an ignore-revs-file?

@thorstenhater
Copy link
Contributor Author

We can do that, but -- I assume -- not before merging this, since we need to commit IDs?

@Helveg
Copy link
Collaborator

Helveg commented Jun 13, 2022

Yes, that's how I've always done it 🤷‍♀️

@thorstenhater
Copy link
Contributor Author

Then I can only say thank you for the hint, will do ;)

Helveg
Helveg approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with black 👍 This makes the '"label"' syntax slightly weirder

brenthuisman
brenthuisman suggested changes Jun 14, 2022
View reviewed changes
@thorstenhater
Copy link
Contributor Author

I agree with black 👍 This makes the '"label"' syntax slightly weirder

How so? Black doesn't seem to touch those. Maybe just maybe, we can
change this to allow "'label'" as well, to keep in style with Python.

@brenthuisman brenthuisman merged commit 48ad369 into arbor-sim:master Jun 16, 2022
brenthuisman added a commit to brenthuisman/arbor that referenced this pull request Jun 24, 2022
@brenthuisman
- Fix line numbers in tutorials, fallout from arbor-sim#1906
daeae7e 
- Mention arbor-contrib in a few relevant places
- Correct some fallout from arbor-sim#1904
- A new hardware and profiling tutorial, and covers things moved out of other examples in arbor-sim#1904
- Various other documentation fixes
@brenthuisman brenthuisman mentioned this pull request Jun 24, 2022
Merged
brenthuisman added a commit that referenced this pull request Jun 30, 2022
@brenthuisman
Fix line numbers in tutorials and assorted doc corrections (#1917)
c38db01 
- Fix line numbers in tutorials, fallout from #1906
- Mention arbor-contrib in a few relevant places
- Correct some fallout from #1904
- A new hardware and profiling tutorial, and covers things moved out of other examples in #1904
- Various other documentation fixes
@thorstenhater thorstenhater deleted the python/paint-it-black branch August 1, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenthuisman brenthuisman brenthuisman approved these changes

@Helveg Helveg Helveg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thorstenhater @brenthuisman @Helveg