-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt flake8 #1908
Adopt flake8 #1908
Conversation
flake8: good idea, but! readme says it's very tied to a Python minor version. You anointed Python 3.9 as standard, but since we want to keep our code compatible down to 3.6 (for now), should then the Action not run with 3.6? Or is this more hassle than it's worth, considering the limited amount of Python? Also, merge master pls. |
# gen-labels.py
def write_morphology(name, morph):
string = "tmp = [".format(name)
for i in range(morph.num_branches): |
Let's go with the sanest choice wrt versions would be to run flake8 at the minimum version we support, 3.6 atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's left are the line numbers in the tutorials. I could take care of it in a follow up too, there's a few more tutorial mistakes left.
# artifacts | ||
build, | ||
# nah, don't care | ||
spack/package.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, they care! They have the same check running.
Line numbers to be fixed after all the convenience, Python formatting, and linting PR are in. |
This builds on top of the previous PRs regarding Python best practices and add the
flake8 linter.