Move Python build to pyproject.toml, bump Python minver to 3.7, fix macos wheel generation
#1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just have not been checking it.)
* Macos Python wheels now come with dual-arch (x86-64 and arm64)
* Testers wanted. I don't have Macs, let alone M1s.
* Moved (nearly) all Python build instructions to `pyproject.toml`
* Enables 'build isolation', and need to specify build-deps only once, no need for users or CI scripts to pre-install them.
* Enables editable `pip` installs (`pip install -e ./arbor`)
* Testers wanted!
* Compatible with 'build frontends' `pip` and `build`.
* Passing CMake options actually got shorter
* Drop Python 3.6 support. This way of building does not work on that version anymore, but does 3.7 up to 3.11beta. I did my best to find the actual reason, or a formal declaration of cease of support, but couldn't find it. I assume something in this rather complex concoction of tooling is perhaps assuming 3.6 is in fact EOL.
Wheels available here: https://github.com/brenthuisman/arbor/actions/runs/2550193753
Closes arbor-sim#1683, arbor-sim#1414, arbor-sim#1409
brenthuisman
added
python
packaging
Helveg
requested changes
Jun 24, 2022
thorstenhater
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.tomlpipinstalls (pip install -e ./arbor)pipandbuild.Wheels available here: https://github.com/brenthuisman/arbor/actions/runs/2550193753
Closes #1683, #1414, #1409