Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing morphologies #1957

Merged
merged 10 commits into from
Sep 7, 2022
Merged

Allow editing morphologies #1957

merged 10 commits into from
Sep 7, 2022

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Aug 23, 2022 •
edited
Loading

Add methods over segment_trees

  • join_at: splice two trees together at a given id
  • split_at: split a tree into two tree at a given id
  • equivalence: two trees represent the same morphology
  • equality: two trees are identical.
  • apply isometry

Allow loading raw segment trees in arborio except NML.

Closes #1589
Closes #1777

This was referenced Aug 24, 2022
Merged
Closed
boeschf
boeschf reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c++ docs are missing. Otherwise looks good.

boeschf
boeschf previously approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

boeschf
boeschf reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@thorstenhater thorstenhater merged commit 276fee9 into arbor-sim:master Sep 7, 2022
@thorstenhater thorstenhater deleted the feat/morph-edit branch September 7, 2022 11:42
@lukasgd lukasgd mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

@bcumming bcumming Awaiting requested review from bcumming

@lukasgd lukasgd Awaiting requested review from lukasgd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate Morphology Ignoring subsets of morphology upon loading (from .swc/.asc etc)
2 participants
@thorstenhater @boeschf