Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pybind11 to /ext #1968

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Move pybind11 to /ext #1968

merged 3 commits into from
Sep 6, 2022

Conversation

brenthuisman
Copy link
Contributor

@brenthuisman brenthuisman mentioned this pull request Sep 5, 2022
Closed
thorstenhater
thorstenhater approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@espenhgn
Copy link
Collaborator

espenhgn commented Sep 6, 2022

Thanks! I tested now this PR on the cluster, however, it does not fix #1951 in case an older pybind11 version is available.

@brenthuisman brenthuisman merged commit 93f1331 into arbor-sim:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorstenhater thorstenhater thorstenhater approved these changes

@espenhgn espenhgn Awaiting requested review from espenhgn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brenthuisman @espenhgn @thorstenhater