Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify make catalogue #2042

Merged
merged 10 commits into from
Nov 22, 2022
Merged

Conversation

boeschf
Copy link
Contributor

@boeschf boeschf commented Nov 17, 2022

Current state:

  • unit tests and an example build their own mechanism catalogue
  • repeated logic for detecting GPUs, passing compile time flags

Proposal:

  • we should leverage the cmake variables and targets which are already there since these catalogues are internal to arbor
    => build a static library with mechanisms, which links to arbor-private-deps

Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like, simplification and a bit of isolation!

@boeschf boeschf merged commit 9797403 into arbor-sim:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants