-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Re-factor FVM lowered cell implementation and shared state #2082
Merged
thorstenhater
merged 36 commits into
arbor-sim:master
from
thorstenhater:qa/refactor-fvm-lowered
Feb 8, 2023
Merged
🧹 Re-factor FVM lowered cell implementation and shared state #2082
thorstenhater
merged 36 commits into
arbor-sim:master
from
thorstenhater:qa/refactor-fvm-lowered
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors try |
tryTimed out. |
boeschf
reviewed
Feb 2, 2023
thorstenhater
commented
Feb 2, 2023
Well, forgot to push the actual changes. |
boeschf
previously approved these changes
Feb 7, 2023
boeschf
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for refactoring. Looks much cleaner now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean-up operation on
fvm_lowered_cell_impl.hpp
and{cpu, gpu}/shared_state.{hpp, cpp}
.shared_state
specifics infvm_lowered_cell_impl
and push these down toshared_state
fvm_lowered_cell
fromshared_state
shared_state_base