Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Re-factor FVM lowered cell implementation and shared state #2082

Merged
merged 36 commits into from
Feb 8, 2023

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Jan 24, 2023

This is a clean-up operation on fvm_lowered_cell_impl.hpp and {cpu, gpu}/shared_state.{hpp, cpp}.

  • Get rid of shared_state specifics in fvm_lowered_cell_impl and push these down to shared_state
  • Present more of an interface layer towards fvm_lowered_cell from shared_state
  • De-duplicate methods across CPU/GPU implementations by adding shared_state_base
  • Align interfaces of GPU/CPU solvers.

@thorstenhater
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jan 24, 2023
@thorstenhater thorstenhater marked this pull request as ready for review January 25, 2023 06:29
@bors
Copy link

bors bot commented Jan 25, 2023

try

Timed out.

@thorstenhater thorstenhater requested a review from boeschf February 3, 2023 11:23
@thorstenhater
Copy link
Contributor Author

Well, forgot to push the actual changes.

boeschf
boeschf previously approved these changes Feb 7, 2023
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for refactoring. Looks much cleaner now.

@thorstenhater thorstenhater merged commit 543331f into arbor-sim:master Feb 8, 2023
@thorstenhater thorstenhater deleted the qa/refactor-fvm-lowered branch February 8, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants