Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DBSCAN test on Intel #1112

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Fix DBSCAN test on Intel #1112

merged 1 commit into from
Jun 22, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Jun 19, 2024

Some rounding stuff on failed on Sunspot. This should be (slightly) more robust.

@aprokop aprokop added the testing Anything to do with tests and CI label Jun 19, 2024

BOOST_TEST(verifyDBSCAN(space, points, r, 2,
toView<DeviceType, int>({1, 1, -1, -1})));
BOOST_TEST(verifyDBSCAN(space, points, r, 3,
toView<DeviceType, int>({-1, -1, -1, -1})));

BOOST_TEST(verifyDBSCAN(space, points, 2 * r, 2,
BOOST_TEST(verifyDBSCAN(space, points, r2, 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2*r with the new definition as a float is not good enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

@aprokop
Copy link
Contributor Author

aprokop commented Jun 21, 2024

SYCL builds are broken due to inability to download oneDPL. Intel has broken something on their website, that file is not fully downloadable (only 11%).

@aprokop aprokop merged commit 7b4c57a into arborx:master Jun 22, 2024
1 of 2 checks passed
@aprokop aprokop deleted the fix_test branch June 22, 2024 15:46
@aprokop aprokop mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything to do with tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants