Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set policy CMP0167 to use FindBoost module #1123

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Set policy CMP0167 to use FindBoost module #1123

merged 1 commit into from
Jul 17, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Jul 17, 2024

Fix #1122 for now.

@aprokop aprokop added the build Build and installation label Jul 17, 2024
dalg24
dalg24 reviewed Jul 17, 2024
View reviewed changes
CMakeLists.txt
if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.30.0)
message(STATUS "Setting policy CMP0167 to use FindBoost module")
cmake_policy(SET CMP0167 OLD)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider doing find_package(Boost CONFIG) instead?

Copy link
Contributor Author

@aprokop aprokop Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. That would not work with Boost 1.56-1.69. I decided to postpone updating minimum boost version.

@aprokop
Copy link
Contributor Author

aprokop commented Jul 17, 2024

I tested locally with CMake 3.30, and it passed.

@aprokop
Copy link
Contributor Author

aprokop commented Jul 17, 2024

@dalg24 Do you have any opposition to merging it in the current form, without worrying about updating Boost versions?

@dalg24
Copy link
Contributor

dalg24 commented Jul 17, 2024

@dalg24 Do you have any opposition to merging it in the current form, without worrying about updating Boost versions?

Not blocking no, but also not seeing it as a priority.
The Boost dependency is not the same nature as the Kokkos one. I feel like bumping the minimum version for Boost is the right choice as compare to what is proposed here.

@aprokop aprokop merged commit b283689 into arborx:master Jul 17, 2024
1 of 2 checks passed
@aprokop aprokop deleted the set_policy branch July 17, 2024 20:24
@aprokop aprokop mentioned this pull request Jul 17, 2024
Closed
@dalg24
Copy link
Contributor

dalg24 commented Jul 17, 2024

The CI reports a CMake warning. Did you make sure it was ok to ignore?

@aprokop
Copy link
Contributor Author

aprokop commented Jul 18, 2024

The CI reports a CMake warning. Did you make sure it was ok to ignore?

  Manually-specified variables were not used by the project:
    Kokkos_ENABLE_DEPRECATED_CODE_3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

Assignees
No one assigned
Labels
build Build and installation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake policy CMP0167 (CMake 3.30 and FindBoost module)
2 participants
@aprokop @dalg24