Refactor space filling curves surrounding code #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
previously requested changes
Oct 11, 2024
Comment on lines
96
to
104
| template <typename ExecutionSpace, typename Values, typename SpaceFillingCurve, | ||
| typename Box> | ||
| inline auto computeSpaceFillingCurvePermutation(ExecutionSpace const &space, | ||
| Values const &values, | ||
| SpaceFillingCurve const &curve, | ||
| Box const &scene_bounding_box) | ||
| { | ||
| auto linear_ordering_indices = | ||
| projectOntoSpaceFillingCurve(space, values, curve, scene_bounding_box); | ||
| return sortObjects(space, linear_ordering_indices); | ||
| } |
There was a problem hiding this comment.
Saves little code to bundle two distinct operations.
I am not convinced it is a good idea to introduce it.
There was a problem hiding this comment.
It does a bit more than that in that it also reduces the amount of used memory as linear_ordering_indices are deallocated automatically once this function returns. This behavior is similar to the original sortPredicatesAlongSpaceFillingCurve.
If a passed function argument is a prvalue, it will be destroyed once we return, as returning a reference to its member does not extend its lifetime.
aprokop
force-pushed
the
remove_batched_queries
branch
from
aaff2d0 to
6160156
Compare
aprokop
force-pushed
the
remove_batched_queries
branch
from
6160156 to
8a7d92b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getGeometryfor prvaluesIf a passed function argument is a prvalue, it will be destroyed once we return, as returning a reference to its member does not extend its lifetime.
projectOntoSpaceFillingCurvefromArborX_TreeConstruction.hpptoArborX_SpaceFillingCurve.hppIt will also be used by the tree traversal now
computeSpaceFillingCurvePermutationthat combinesprojectOntoSpaceFillingCurvewith sorting to further reduce the amount of codePredicateIndexablesto easily iterate over predicate geometries