Clean up ArborX.hpp #1202
Open
Clean up ArborX.hpp #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly to start a discussion about what headers should a user get when including
ArborX.hpp.As I see it, there are two options:
ArborX.hpp(other than included through indexes), and has to include each individual geometry they want to useI see an issue with the first approach as a user will be transitively dependent on the geometries. If we change anything internally about inclusions, that will break user's code through no fault of their own. On the other hand, including all geometries is including a lot of code.
I'd like feedback on this.