Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Added loading state for conversation list #1343

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JeevaRamanathan
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix / enhancement
  • Why was this change needed? (You can also link to an open issue here)
    There is no indication that the conversations are fetching in sidebar. Added a loader state and icon to indicate it's loading. Resolves 🐛 Bug Report: Enhancement - Add Loader Icon for Fetching List of Conversations #1342
  • Other information:
    Without introducing separate variable I have just extended the conversations object. Please let me know if you suggest any other alternative approaches as well.

Copy link

vercel bot commented Oct 19, 2024

@JeevaRamanathan is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@JeevaRamanathan JeevaRamanathan changed the title Enhancement/conversation loading state Enhancement: Added loading state for conversation list Oct 19, 2024
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ❌ Failed (Inspect) Oct 22, 2024 10:01pm

@dartpain
Copy link
Contributor

dartpain commented Oct 21, 2024

Can you please provide some screenshots, thank you!

@JeevaRamanathan
Copy link
Contributor Author

JeevaRamanathan commented Oct 22, 2024

Hi @dartpain, in the Expected behavior of this issue #1342 (comment) I have added the demo video.
As some other changes was added into the file, I will look into it and resolve the conflict.
Thanks!

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.45%. Comparing base (567c01e) to head (1e88c86).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   34.15%   33.45%   -0.71%     
==========================================
  Files          63       64       +1     
  Lines        3200     3273      +73     
==========================================
+ Hits         1093     1095       +2     
- Misses       2107     2178      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dartpain
Copy link
Contributor

Really appreciate it, thank you

  1. Im not sure that vercel is compiling it successfully
src/store.ts(26,5): error TS2322: Type 'null' is not assignable to type '{ data: { name: string; id: string; }[] | null; loading: boolean; }'.
Error: Command "npm run build" exited with 2
  1. @tenokami can you check out the design please if thats the way to handle it or any adjustments

@tenokami
Copy link
Collaborator

@dartpain @JeevaRamanathan I'd suggest moving loader to the middle/center and all good
image

Signed-off-by: JeevaRamanathan M <jeevaramanathan.m@infosys.com>
@JeevaRamanathan
Copy link
Contributor Author

JeevaRamanathan commented Oct 22, 2024

Hi,

  1. @dartpain I missed changing the preloading state, it's fixed now.
  2. @tenokami I have moved it to center but noticed one thing, as fetchConversations is called while deleting conversation here to refresh the list, the loader appears in center. Your thoughts on this, is that ok?
23.10.2024_04.02.02_REC.mp4

@tenokami
Copy link
Collaborator

@JeevaRamanathan Frankly, that's not ideal...

@JeevaRamanathan
Copy link
Contributor Author

JeevaRamanathan commented Oct 22, 2024

@tenokami the loader will not display if it's delete conversation. Does this align?

23.10.2024_04.39.45_REC.mp4

Signed-off-by: JeevaRamanathan M <jeevaramanathan.m@infosys.com>
@tenokami
Copy link
Collaborator

@JeevaRamanathan yes! thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Enhancement - Add Loader Icon for Fetching List of Conversations
3 participants