Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Ingestor types for remote resources in Upload Component #1610

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Jan 30, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

    • Separate the configurations for different remote upload options by structuring interfaces.
    • Adding form schema to generate form elements dynamically based on the IngestorType
    • Form fields are rendered as
      • string/number as Input component
      • boolean as ToggleSwitch component
      • enums as Dropdown component
  • Why was this change needed? (You can also link to an open issue here)
    Maintenance

Copy link

vercel bot commented Jan 30, 2025

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.80%. Comparing base (8c91864) to head (5c5b730).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1610   +/-   ##
=======================================
  Coverage   34.80%   34.80%           
=======================================
  Files          76       76           
  Lines        3821     3821           
=======================================
  Hits         1330     1330           
  Misses       2491     2491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant