Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable completions, update eldoc + eldoc for static clr methods #389

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Enable completions, update eldoc + eldoc for static clr methods #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2cecd81
Make nrepl fixes
benjamin-asdf Jul 20, 2022
b4e6459
Put port into config
benjamin-asdf Aug 6, 2022
87e296a
Format and add ports
benjamin-asdf Aug 6, 2022
86a4f82
Remove log
benjamin-asdf Aug 6, 2022
a100f72
Comment out warning
benjamin-asdf Aug 6, 2022
daf54ce
Fix whitespace, config port
benjamin-asdf Aug 6, 2022
7b88f31
Implement eldoc for static methods
benjamin-asdf Aug 7, 2022
f6d746e
Add todo
benjamin-asdf Feb 15, 2023
42c46ea
Update whitespace
benjamin-asdf Feb 15, 2023
98164eb
Format
benjamin-asdf Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Editor/ArcadiaProjectInitialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ static ArcadiaProjectInitialization()

public static void CheckSettings()
{
Debug.Log("Checking Unity Settings...");
if (!Application.unityVersion.StartsWith("2018")) // gross string comparison, not sure we can avoid
{
Debug.LogWarningFormat("Expected Unity version 2018.x, got {0}. This might cause issues.", Application.unityVersion);
}

//Debug.Log("Checking Unity Settings...");
//if (!Application.unityVersion.StartsWith("2018")) // gross string comparison, not sure we can avoid
//{
//Debug.LogWarningFormat("Expected Unity version 2018.x, got {0}. This might cause issues.", Application.unityVersion);
//}

if (PlayerSettings.GetApiCompatibilityLevel(BuildTargetGroup.Standalone) != ApiCompatibilityLevel.NET_4_6)
{
Expand Down
2 changes: 1 addition & 1 deletion Editor/Initialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public static void Initialize()
NRepl.StartServer();
#endif
StartNudge();
Debug.Log("Arcadia Started!");
//Debug.Log("Arcadia Started!");

initialized = true;
}
Expand Down
Loading