-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for volume options #46
Labels
enhancement
New feature or request
Comments
rh-tguittet
added a commit
to rh-tguittet/arcaflow-engine-deployer-podman
that referenced
this issue
Feb 26, 2024
Signed-off-by: Thibault Guittet <88336850+rh-tguittet@users.noreply.github.com>
This was referenced Feb 26, 2024
webbnh
pushed a commit
to webbnh/arcaflow-engine-deployer-podman
that referenced
this issue
Mar 26, 2024
Signed-off-by: Thibault Guittet <88336850+rh-tguittet@users.noreply.github.com>
webbnh
pushed a commit
to webbnh/arcaflow-engine-deployer-podman
that referenced
this issue
Mar 27, 2024
Signed-off-by: Thibault Guittet <88336850+rh-tguittet@users.noreply.github.com>
webbnh
pushed a commit
to webbnh/arcaflow-engine-deployer-podman
that referenced
this issue
Mar 28, 2024
Signed-off-by: Thibault Guittet <88336850+rh-tguittet@users.noreply.github.com>
webbnh
added a commit
that referenced
this issue
Mar 29, 2024
* Fix #46 Support for volumes with 3 parts Signed-off-by: Thibault Guittet <88336850+rh-tguittet@users.noreply.github.com> * Reposition the t.Cleanup() invocations so that they might have a chance of being useful if the test actually fails or crashes. * Remove the various timing Sleep() calls and replace them with loops which wait for the required datum to appear; this addresses at least one of the flakey tests which was failing occasionally in the CI. * Fix a bug in TestCgroupNsByNamespacePath() where we were fetching the same datum twice and checking that it was the same, instead of fetching the corresponding values from the two different containers. * Rework readOutputUntil() to avoid a bug where it might omit from the returned value the last buffer read when an error such as EOF occurs. * Inline checkIfconfig(), since it's used in only one place and it could be reduced to a single line. * Replace a number of uses of assert.NoError() with assert.NoErrorR(). * Change the existing TestSimpleVolume() function into a helper function which is called repeatedly by each of three new tests which use a table to generate the various scenarios. The three tests correspond to three host platform types -- non-Linux, SELinux, and Linux with SELinux disabled -- and the tests mark themselves as "skipped" if they don't match the host platform. Modify the test to create the bind-mounted file on the fly, so that sharing the same file between the containers doesn't lead to conflict; tighten up the pass/fail assertion. --------- Signed-off-by: Thibault Guittet <88336850+rh-tguittet@users.noreply.github.com> Co-authored-by: Thibault Guittet <88336850+rh-tguittet@users.noreply.github.com> Co-authored-by: Thibault Guittet <tguittet@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please describe what you would like to see in this project
Due to this check in argsbuilder, only volumes passed as
./source:/container-dir
are supported.Please describe your use case
Options are required SELinux re-labeling. My resulting volume configuration looks like so:
./source:/container-dir:z
.Note that several options can be passed for a volume as a comma separated string.
Here is my config.yaml file:
The text was updated successfully, but these errors were encountered: