Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Changes #31

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Config Changes #31

merged 5 commits into from
Nov 21, 2023

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

NOTE: Workflows will need to be updated if they used any of the removed or changed fields.

This updates the Podman deployer to:

  • Use the same config format as the Docker deployer when possible.
  • Remove duplicate fields, where one field previously did nothing.
  • Disable the fields that are not used, but are shared with the Docker deployer.
  • Fix tests for Mac OS.
  • Replace OS and Arch with platform, since that's the format used by both Podman and Docker. The validation is still done with a regular expression.
  • Remove clunky test configuration fields.

By contributing to this repository, I agree to the contribution guidelines.

Removed godotenv, made it use the podman version in path instead of hard-coded path, and disabled a test when not on linux
Signed-off-by: Dustin Black <dblack@redhat.com>
@dustinblack dustinblack merged commit 88b8a20 into main Nov 21, 2023
4 checks passed
@dustinblack dustinblack deleted the config-changes branch November 21, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants