Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --atp to invoke ATP mode #5

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Added --atp to invoke ATP mode #5

merged 1 commit into from
Feb 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2023

Changes introduced with this PR

This change adds the --atp command line option to invoked plugins to actually invoke plugins in the ATP mode.

Test:

/tmp/GoLand/___go_build_go_flow_arcalot_io_engine_cmd_run_plugin -image arcaflow-example-plugin -file example.yaml -step hello-world
debugLogs: null
outputData:
    message: Hello, Arca Lot!
outputID: success
2023-02-21T17:56:38+01:00       warning         failed to kill pod arcaflow_podman_pqlN8, probably the execution terminated earlier
2023-02-21T17:56:38+01:00       info            successfully removed container arcaflow_podman_pqlN8
2023-02-21T17:56:38+01:00       info            stdin pipe successfully closed
2023-02-21T17:56:38+01:00       info            stdout pipe successfully closed

By contributing to this repository, I agree to the contribution guidelines.

@ghost ghost marked this pull request as ready for review February 21, 2023 16:57
@ghost ghost self-requested a review February 21, 2023 16:57
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming the test passes after a retry. If not, it should be good once that's fixed.

@jaredoconnell jaredoconnell merged commit c0d063a into main Feb 21, 2023
@jaredoconnell jaredoconnell deleted the add-atp branch February 21, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant