-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add privileged config option #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this have to be translated to --privileged
somewhere for the podman
command?
And any intent to do this for the docker deployer as well? (Not that I'm complaining: everyone should use podman anyway. 😆 )
Afaik, no, but I will verify more completely. I've never seen any program where you have to enable the use of a CLI option through the configuration of another file. Usually, they are just different entry points with different levels of precedence to alter same the behavior. |
Okay yeah I did need to implement the behavior the argsbuilder interface and call it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; one suggestion.
Changes introduced with this PR
Add podman privileged as a config option for the deployer.
Privileged container execution reference.
By contributing to this repository, I agree to the contribution guidelines.