-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function getEnvVar() #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I'm not thrilled about the function name and you're also missed a reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second Dave's comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it's weird that a change like this doesn't invalidate my previous ✅ ... but I'll give you another ✅ anyway for your collection. 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it's weird that a change like this doesn't invalidate my previous ✅ .
You should talk to the repo owner about getting that setting fixed. 😆
Changes introduced with this PR
This is a simple function to get en env variable. This has many potential uses, including getting the kubeconfig location from the KUBECONFIG environment variable.
By contributing to this repository, I agree to the contribution guidelines.