Inlined object fields #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This allows single-field objects to be specified in the serialized data as the single field.
This is useful when writing schemas for externally written libraries like the Kubernetes lib. There is a Format type that has all private fields except for the format string itself. In this case the extra level of indentation does not add anything to the clarity of the input.
Example:
can now be done as:
since it only has one field.
The potential con of this feature is potential confusion. However, I think it's at least partially outweighed by the potential simplification of the serialized data inputs. In addition, I think the error messages that I added should help when the values are inlined.
This PR also includes some additional test cases for objects that are not directly related to these changes.
By contributing to this repository, I agree to the contribution guidelines.