Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build artifact uploads #123

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix build artifact uploads #123

merged 1 commit into from
Mar 18, 2024

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Mar 15, 2024

Changes introduced with this PR

As of v4 of actions/upload-artifact, "it is no longer possible to upload to the same named Artifact multiple times." However, the current build runs repeatedly, for each of Python 3.9, 3.10, and pypy3.9, each of which uploads a number of artifacts, most of which have the same name in each run. So, on the second run, the attempt to upload the coverage HTML artifact now fails, or, at least, it did in #122 (it is possible that the problem is timing-related -- it did not happen in #120 or #119).

This change extends the changes in #120 to the other pushed artifacts, so that they have unique names suffixed with the version of Python used in the run.

This change also relaxes the version of Poetry used from 1.4.2 to any 1.4.


By contributing to this repository, I agree to the contribution guidelines.

@webbnh webbnh requested review from dustinblack, jaredoconnell, dbutenhof and a team March 15, 2024 20:11
@webbnh webbnh self-assigned this Mar 15, 2024
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it looks plausible!

Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I wonder if Poetry cares about that version at all. Probably not because it's in a run block.

@mfleader mfleader self-requested a review March 18, 2024 20:38
@webbnh
Copy link
Contributor Author

webbnh commented Mar 18, 2024

I wonder if Poetry cares about that version at all. Probably not because it's in a run block.

This is the installation of Poetry...so, it doesn't get to think about this -- rather, this controls what Poetry gets to think! 🙃

@webbnh webbnh merged commit 316d325 into arcalot:main Mar 18, 2024
4 checks passed
@webbnh webbnh deleted the artifact-upload branch March 18, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants