Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #40

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Update all dependencies #40

merged 1 commit into from
Jun 18, 2024

Conversation

redhat-renovate-bot
Copy link
Contributor

@redhat-renovate-bot redhat-renovate-bot commented Jun 3, 2024

This PR contains the following updates:

Package Type Update Change
arcaflow-plugin-sdk dependencies minor ^0.13.0 -> ^0.14.0
quay.io/arcalot/arcaflow-plugin-baseimage-python-buildbase stage minor 0.3.1 -> 0.4.2
quay.io/arcalot/arcaflow-plugin-baseimage-python-osbase final minor 0.3.1 -> 0.4.2

Release Notes

arcalot/arcaflow-plugin-sdk-python (arcaflow-plugin-sdk)

v0.14.0

Compare Source

What's Changed

New Contributors

Full Changelog: arcalot/arcaflow-plugin-sdk-python@0.13.0...0.14.0


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copy link

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete: the Renovate bot is hitting some sort of error (for which it is no longer posting details) trying to generate the poetry.lock file, which results in the CI jobs failing.

Moreover, the bot reused the branch from #39 which has an old commit from the previous bot on it, which is why we're seeing the Edited/Blocked Notification, instead of re-creating the branch from scratch.

Once I get the go ahead from the Renovate folks, I'm going to close this PR and delete its branch; then we'll let the bot try again from scratch and see if things work better.

Dockerfile Outdated
FROM quay.io/arcalot/arcaflow-plugin-baseimage-python-buildbase:0.3.1 as build
FROM quay.io/arcalot/arcaflow-plugin-baseimage-python-buildbase:0.4.0 as build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dustinblack, you mentioned in the Community meeting that this change will result in switching from CentOS Stream 8 to Stream 9. Is that likely to pose a problem for this plugin, and, if so, will the CI detect them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin self-tests should generally be adequate to find any problems introduced by the change from stream-8 to stream-9. The usual problems in this case are that a dependency is changed via a version-bumped RPM package, which results in new input or output that breaks the schema, which our typical plugin tests should catch. This is a very simple plugin without package dependencies, and the CI tests have passed, so I think the change to stream-9 is perfectly fine here.

Copy link

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks to me to be ready to merge, now: the Renovate bot issues have been addressed -- the bot generated a new branch, and the CI seems satisfied with it.

@dustinblack, any thoughts on my question above?

Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: redhat-renovate-bot <redhat-internal-renovate@redhat.com>
Copy link

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks ready to merge again, pending the OK from Dustin.

Dockerfile Outdated Show resolved Hide resolved
@webbnh webbnh merged commit e111e18 into main Jun 18, 2024
4 checks passed
@webbnh webbnh deleted the renovate/all branch June 18, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants