Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow reusing the command to launch two kernels #1790

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

grospelliergilles
Copy link
Member

It was never allowed but there was no test to check it.
Re-using the same command will make profiling results wrong and may also have unknown side effects.
We can temporarily set the environment variable ARCANE_ACCELERATOR_ALLOW_REUSE_COMMAND to 1 allows to revert to previous behavior.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup arcane:accelerator Arcane Accelerator API/Runtime labels Nov 24, 2024
@grospelliergilles grospelliergilles self-assigned this Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.22%. Comparing base (6510f63) to head (2e23286).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...cane/src/arcane/accelerator/core/RunCommandImpl.cc 0.00% 6 Missing and 2 partials ⚠️
...cane/tests/accelerator/AcceleratorViewsUnitTest.cc 97.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   70.24%   70.22%   -0.03%     
==========================================
  Files        2258     2258              
  Lines      162343   162364      +21     
  Branches    18698    18703       +5     
==========================================
- Hits       114036   114017      -19     
- Misses      41537    41572      +35     
- Partials     6770     6775       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit a780c35 into main Nov 24, 2024
32 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-disallow-reusing-command branch November 27, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant