Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for v11 and closes #10 #82

Merged
merged 18 commits into from
Aug 22, 2023
Merged

Fixed for v11 and closes #10 #82

merged 18 commits into from
Aug 22, 2023

Conversation

gioppoluca
Copy link
Collaborator

This makes the module work in V11 and fixes incompatibility with latest DND5e

@gioppoluca
Copy link
Collaborator Author

I fixed the traits.toolProf in a way that leave it compatible with older DND5e versions, but the most recent has moved that object here: system.tools
So either a more complex management or a breaking change to go with only latest version. Up to you ... apart that all should work

@gioppoluca
Copy link
Collaborator Author

wrong # ... it closes #81 sorry

@ChrisAndelin
Copy link

I tested this and it didn't throw any errors.
image

@naesean
Copy link

naesean commented Aug 3, 2023

@gioppoluca any chance this can get merged and released? Would love to use this for my v11 games. Thanks so much!

@gioppoluca
Copy link
Collaborator Author

I added the german fixes and fixed the dnd5e mapping
Also added the initial mapping for the spellbook template

Copy link
Owner

@arcanistzed arcanistzed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the PDF? Do you have license to use it and the ODT here? If so, re you releasing it under this repository's MIT or do you need to include another license file?

@gioppoluca gioppoluca self-assigned this Aug 18, 2023
Copy link
Collaborator Author

@gioppoluca gioppoluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes things for V11

@gioppoluca gioppoluca merged commit f5cbd7a into arcanistzed:main Aug 22, 2023
@naesean
Copy link

naesean commented Aug 24, 2023

Looking forward to seeing this released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants