Refactor the codebase #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SachiraKuruppu
commented
Sep 13, 2023
SachiraKuruppu
commented
- Extract the RAG e2e training script process_function into utils -- To declutter the training script.
- Rename train.py module in utils folder to train_utils.py -- Make it clear that these are util functions.
- Move base models out of the training folder to a separate folder -- These models are used in evaluation too. Not ideal to keep them in the training folder.
shamanez
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
let's change the name of this : peft_lora_constrastive_learning.py -->> retriever_only.py
There was a problem hiding this comment.
Renamed this to train_retriever_only.py to be consistent with the rag_e2e training script.
SachiraKuruppu
force-pushed
the
refactor
branch
from
82a5ef1
to
587e2d6
Compare
Unused imports will cause tests to fail, so we should be okay there |
Ben-Epstein
reviewed
Sep 13, 2023
| @@ -13,13 +13,18 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| import os | |||
| import sys | |||
|
|
|||
There was a problem hiding this comment.
This should not be necessary if you are installing the package. Can we remov this?
|
@rsachira can you remove the line Then it won't be necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.