Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accelerator issue #16

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Fix accelerator issue #16

merged 6 commits into from
Sep 13, 2023

Conversation

SachiraKuruppu
Copy link
Contributor

  • Provide the complete model (rag_model) to the accelerator instead of giving the retriever and the generator separately.
  • Change the forward path to use the retriever or the generator based on the task string.

This declutters the training code.

@SachiraKuruppu
Copy link
Contributor Author

This needs a bit more work:

  • Add arguments to AutoModelForRagE2E to load the model for inference with peft layers.
  • Fixdalm/eval/eval_with_hnsw.py use of rag_model.forward(...) function.

I'll have a look tomorrow, or feel free to fix these.

Copy link
Member

@shamanez shamanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@shamanez shamanez merged commit 86d598a into main Sep 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants