Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take max length as CLI parameters #27

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Take max length as CLI parameters #27

merged 3 commits into from
Sep 17, 2023

Conversation

SachiraKuruppu
Copy link
Contributor

  • There is an existing argparser parameter for max_length. Use that within the train_retriever_only.py
  • Rename training utils files to *_dataloader_utils.py, because they only contain dataloader preprocessing functions

@SachiraKuruppu SachiraKuruppu merged commit e3e2f21 into main Sep 17, 2023
1 check passed
@SachiraKuruppu SachiraKuruppu deleted the take-max-length-as-param branch September 17, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ben-Epstein Ben-Epstein Ben-Epstein approved these changes

@shamanez shamanez shamanez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SachiraKuruppu @shamanez @Ben-Epstein