revisited the README and max token lengths #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shamanez
commented
Sep 17, 2023
shamanez
commented
- added max_token_len variables
- corrected the path
- checked readme executions for training end2end
SachiraKuruppu
suggested changes
Sep 17, 2023
| type=int, | ||
| default=128, | ||
| help=( | ||
| "The maximum total input sequence length after tokenization. Sequences longer than this will be truncated," | ||
| "The maximum total passage sequence length after tokenization. Sequences longer than this will be truncated," | ||
| " sequences shorter will be padded if `--pad_to_max_length` is passed." |
There was a problem hiding this comment.
Is the parameter --pad_to_max_length defined? I can't see it in the file.
| sys.path.append(os.getcwd()) # This is needed to import modules with absolute paths | ||
|
|
||
| # ruff: noqa: E402 | ||
|
|
There was a problem hiding this comment.
I would remove this empty line.
There was a problem hiding this comment.
- There is a
--pad_to_max_lengthparameter referenced in argparser hints, but is not defined. - Should we also use
query_max_lengthandpassage_max_lengthparameters in this script similar to thetrain_rage2e.pyscript?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.