OSS work: sdk and cli support for training retriever, e2e, and qa-gen, license #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Epstein
requested review from
SachiraKuruppu and
shamanez
and removed request for
SachiraKuruppu
2 tasks
shamanez
previously requested changes
Sep 17, 2023
README.md
Outdated
| ```shell | ||
| git clone https://github.com/arcee-ai/DALM.git && cd DALM | ||
| python -m venv .venv && source .venv/bin/activate | ||
| pip install invoke |
There was a problem hiding this comment.
What is this? I have never heard of this before.
also, how can users install the dependencies?
There was a problem hiding this comment.
this is how you install the dependencies. I added instructions to instlal without invoke, you don't need it, but it helps organize, like a Makefile
| Alternatively, for development or research, you can clone and install the repo locally: | ||
| ```shell | ||
| git clone https://github.com/arcee-ai/DALM.git && cd DALM | ||
| pip install --upgrade -e . |
metric-space
approved these changes
Sep 19, 2023
shamanez
requested changes
Sep 19, 2023
| use_peft: Annotated[bool, typer.Option(help="Whether to use Peft during fine-tuning.")] = True, | ||
| ) -> None: | ||
| """End-to-end train an in-domain model, including the retreiver and generator""" | ||
| train_e2e( |
There was a problem hiding this comment.
Can we make this file a bit more simplified? I feel like too many arguments passing here and there.
There was a problem hiding this comment.
I'm not sure what you mean? It's just the 1 function. This is identical to how we have it with argparse https://github.com/arcee-ai/DALM/blob/main/dalm/training/rag_e2e/train_rage2e.py#L58-L211
Why is this confusing but argparse isn't?
shamanez
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dalmthat can be called post installdalmclicloses #22
closes #21
closes #15