New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align names to rage2e params #52

Merged

Ben-Epstein merged 2 commits into main from align-param-names

Sep 21, 2023

Contributor

Ben-Epstein commented Sep 21, 2023 •

edited

Loading

unified all of our slightly different parameter names

retriever_model_name_or_path -> retriever_name_or_path
generator_model_name_or_path -> generator_name_or_path
dataset_passage_col_name -> passage_column_name
dataset_query_col_name -> query_column_name
dataset_title_col_name -> title_column_name
dataset_answer_col_name -> answer_column_name
answer_col_name -> answer_column_name
passage_col_name -> passage_column_name


          align names to rage2e params

865cff3

Ben-Epstein requested a review from shamanez

September 21, 2023 22:06


          align param names

ec6c627

shamanez approved these changes

View reviewed changes

Member

shamanez left a comment

looks good

Ben-Epstein merged commit 73fc83e into main

1 check passed

Ben-Epstein deleted the align-param-names branch

September 21, 2023 23:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet