Map rag model to device in eval rag script

[sagorbrur]

Hi,
According to our discussion on issue #73 , here I have added device mapping in eval_rag.py.
I have tested and no device mismatch error raising now.

Please have a look and merge if everything is okay.

Thanks and regards

[shamanez]

looks good to me!

[shamanez]

@sagorbrur
Maybe let's add this code snippet here:

Also let's add a comment above this line
rag_model.attach_pre_trained_peft_layers(retriever_peft_model_path, generator_peft_model_path, device)

Something like - "we only wrap this with PEFT layers if there are any ... :

Thanks a lot :)

DALM/dalm/models/rag_e2e_base_model.py

Line 135 in a847640

[sagorbrur]

HI @shamanez ,

@sagorbrur Maybe let's add this code snippet here:

Also let's add a comment above this line rag_model.attach_pre_trained_peft_layers(retriever_peft_model_path, generator_peft_model_path, device)

Something like - "we only wrap this with PEFT layers if there are any ... :

Thanks a lot :)

DALM/dalm/models/rag_e2e_base_model.py

Line 135 in a847640

The line you refer I am a little bit confused about where to put it.
It would be great if you clarify a bit.

regards

[metric-space]

Hey @sagorbrur is the comment part unclear or is the request to move the code to the specified location unclear?

[sagorbrur]

Hey @sagorbrur is the comment part unclear or is the request to move the code to the specified location unclear?

Hi @metric-space ,
I am unclear about moving the part to the specified location.
I am requesting maintainers to apply that.
Please if possible add the modification in desired location.

Kind regards