BUG: BestSource never works

[ipid]

Thanks for your Aegisub fork! Your fork has fixed a lot of bugs in Aegisub, and also integrated a lot of useful features that greatly improved my efficiency in creating subtitles.

Recently I found that Aegisub always crashes after I set the audio or video source to BestSource. I've tried every video on my computer, and no matter what kind of video I open, BestSource doesn't seem to work. FIX: I've tried many videos and it seems that video generated by Adobe Premiere makes BestSource crash.

Is this a known issue, or is it just not working on my machine?

[arch1t3cht]

It depends on what you mean. The BestSource video source is indeed extremely slow (it's only there as a safe fallback for videos where everything else fails) so it's normal for Aegisub to "freeze" for multiple minutes when loading it.
Regarding the audio source, I've had one or two crashes happening after fully caching audio loaded with BestSource, but it never happened reliably. If you only set the audio source, does it always crash, and if so, when exactly?

[seproDev]

I just attempted to use the BestSource video source on my machine and with every video I tried so far I first get the error message Timecodes are out of order in the scanning log window. While the first frame loads successfully on scrubbing Aegisub crashes.

Using Windows 10 with the Feature Release 09.

Here the crashlog.txt, though it's not really meaningful.

Attaching WinDbg, on crash I get: (390c.3af0): Integer divide-by-zero - code c0000094 (first chance)
Though, the real problem is likely with the scanning before. Occasionally and only on some files, I also get Couldn't read frame!

[ipid]

As for the video source

I had exactly the same bug as @seproDev's.

First I want to amend my statement: not all videos cause BestSource to crash, but videos generated by Adobe Premiere do.

Here I got 2 videos. One is Video-downloaded-from-Twitter.mp4 and another is Video-generated-by-Adobe-Premiere.mp4.

I've set both Video provider and Audio provider to BestSource:

It opens the video from Twitter successfully but it outputs the length of each frame to be 1h20min:

And after opening the video from Premiere Pro, it reports Timecodes are out of order:

When I try to seek a frame other than the first frame, Aegisub crashes:

Let me provide the video sample here:

test-videos.zip

> sha256sum test-videos.zip
100e5e15855dd2073c51b30f2dc2b8521b878ec14d17b694c383586ccd98c800 *test-videos.zip

I'm using Win10 21H2 and the latest release (the portable one).

For Audio Source

Seems working fine.

[arch1t3cht]

Thanks for the detailed report, this was a very dumb mistake. I'm surprised the previous state even worked for the videos I tested.
I pushed a fix that makes the two videos above work for me, you can try it on this build.
Github autoclosed the issue after I pushed, but feel free to reopen it if there's still more issues.

[seproDev]

Tested out the build and most videos work now.
I still have this one video which crashes similarly, but only if it is the first video loaded.
To replicate. Delete the bsindex folder and load this video. The error message is Couldn't read frame!

[arch1t3cht]

Hopefully fixed with this build.

[seproDev]

Could you, re-run the windows build? It randomly failed.

[arch1t3cht]

Yup, done.

[ipid]

The Windows build works fine on my machine! Thank you very much!