Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow widget validation issues in multi-tile component #11194

Open
wants to merge 5 commits into
base: dev/7.5.x
Choose a base branch
from

Conversation

SDScandrettKint
Copy link
Member

@SDScandrettKint SDScandrettKint commented Jul 16, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Raise validation errors in multi-tile workflow.

Issues Solved

Closes #11193

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

TODO: Retain nodes on left side of page - even attempting to edit the tile doesn't bring back nodes. Pretty vital to get this sorted before this PR can be merged.

@SDScandrettKint SDScandrettKint self-assigned this Jul 16, 2024
@aj-he
Copy link
Contributor

aj-he commented Aug 13, 2024

@SDScandrettKint - can you clear the conflict for it to be reviewed?

@SDScandrettKint
Copy link
Member Author

Update: Latest commits get the node list to remain, as well as keeping errored tiles in the stored list on the right hand side. The latter currently only works for when all tiles saved have validation errors. If one tile has no validation errors, then all tiles will disappear from the right side list.

@SDScandrettKint
Copy link
Member Author

SDScandrettKint commented Sep 19, 2024

Update:
Bringing tiles back by overwriting self.tiles() with the error tiles means that savedData (used for going back a step and seeing all that have been saved) shows the wrong list of tiles.
Tiles added to self.savedData search self.tiles() which will have had all tiles removed to favour fixing error tiles.
Saving only one tile which has an error in and saving brings back an empty tile with all values as None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants